flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink pull request #5200: [FLINK-8306] [kafka] Introduce KafkaOffsetCommitte...
Date Mon, 08 Jan 2018 10:57:26 GMT
Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5200#discussion_r160112834
  
    --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBase.java
---
    @@ -559,6 +565,7 @@ public void onException(Throwable cause) {
     		//            the fetchers 'snapshotCurrentState()' method return at least
     		//            the restored offsets
     		this.kafkaFetcher = fetcher;
    +		this.kafkaOffsetCommitter = createOffsetCommitter();
    --- End diff --
    
    Changing order of those lines:
    ```
    		this.kafkaFetcher = fetcher;
    		this.kafkaOffsetCommitter = createOffsetCommitter();
    ```
    will brake the code. This is super fragile and is kind of hard to follow. 


---

Mime
View raw message