flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #5194: [FLINK-8233][flip6] Add JobExecutionResultHandler
Date Mon, 08 Jan 2018 11:54:20 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5194#discussion_r160126458
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/JobExecutionResultHandlerTest.java
---
    @@ -0,0 +1,160 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.rest.handler.job;
    +
    +import org.apache.flink.api.common.JobID;
    +import org.apache.flink.api.common.time.Time;
    +import org.apache.flink.runtime.concurrent.FutureUtils;
    +import org.apache.flink.runtime.jobmaster.JobExecutionResult;
    +import org.apache.flink.runtime.messages.FlinkJobNotFoundException;
    +import org.apache.flink.runtime.messages.JobExecutionResultNotFoundException;
    +import org.apache.flink.runtime.rest.handler.HandlerRequest;
    +import org.apache.flink.runtime.rest.handler.RestHandlerException;
    +import org.apache.flink.runtime.rest.messages.EmptyRequestBody;
    +import org.apache.flink.runtime.rest.messages.JobMessageParameters;
    +import org.apache.flink.runtime.rest.messages.job.JobExecutionResultResponseBody;
    +import org.apache.flink.runtime.rest.messages.queue.QueueStatus;
    +import org.apache.flink.runtime.webmonitor.RestfulGateway;
    +import org.apache.flink.runtime.webmonitor.retriever.GatewayRetriever;
    +import org.apache.flink.util.ExceptionUtils;
    +
    +import org.apache.flink.shaded.netty4.io.netty.handler.codec.http.HttpResponseStatus;
    +
    +import org.junit.Before;
    +import org.junit.Test;
    +import org.mockito.Mock;
    +import org.mockito.MockitoAnnotations;
    +
    +import java.util.Collections;
    +import java.util.concurrent.CompletableFuture;
    +import java.util.concurrent.CompletionException;
    +import java.util.concurrent.ExecutionException;
    +
    +import static org.hamcrest.Matchers.equalTo;
    +import static org.hamcrest.Matchers.instanceOf;
    +import static org.hamcrest.Matchers.not;
    +import static org.hamcrest.Matchers.nullValue;
    +import static org.junit.Assert.assertThat;
    +import static org.junit.Assert.fail;
    +import static org.mockito.Matchers.any;
    +import static org.mockito.Mockito.when;
    +
    +/**
    + * Tests for {@link JobExecutionResultHandler}.
    + */
    +public class JobExecutionResultHandlerTest {
    +
    +	private static final JobID TEST_JOB_ID = new JobID();
    +
    +	private JobExecutionResultHandler jobExecutionResultHandler;
    +
    +	@Mock
    +	private RestfulGateway mockRestfulGateway;
    --- End diff --
    
    Maybe we should implement a `TestingRestfulGateway` which we can use instead of Mockito.


---

Mime
View raw message