flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #5182: [FLINK-8162] [kinesis-connector] Emit Kinesis' mil...
Date Mon, 08 Jan 2018 12:28:35 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5182#discussion_r160132296
  
    --- Diff: flink-metrics/flink-metrics-core/src/main/java/org/apache/flink/metrics/groups/UnregisteredMetricsGroup.java
---
    @@ -107,7 +107,7 @@ public MetricGroup addGroup(String key, String value) {
     
     	@Override
     	public Map<String, String> getAllVariables() {
    -		return Collections.emptyMap();
    +		return new HashMap<>();
    --- End diff --
    
    is this change necessary?


---

Mime
View raw message