flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #5182: [FLINK-8162] [kinesis-connector] Emit Kinesis' mil...
Date Mon, 08 Jan 2018 12:28:35 GMT
Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5182#discussion_r160132062
  
    --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
---
    @@ -542,6 +545,16 @@ public int registerNewSubscribedShardState(KinesisStreamShardState
newSubscribed
     		}
     	}
     
    +	/**
    +	 * Registers a metric group associated with the shard id of the provided {@link KinesisStreamShardState
shardState}.
    +	 */
    +	private MetricGroup buildMetricGroupForShard(KinesisStreamShardState shardState) {
    +		return runtimeContext
    +			.getMetricGroup()
    +			.addGroup("Kinesis")
    +			.addGroup("shard_id", shardState.getStreamShardHandle().getShard().getShardId());
    --- End diff --
    
    Is the underscore important? Would prefer shardId for consistency.


---

Mime
View raw message