flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery
Date Mon, 08 Jan 2018 12:45:53 GMT
Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5239#discussion_r160135285
  
    --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
    @@ -831,11 +834,12 @@ private StreamStateHandle materializeStateData(Path filePath) throws
Exception {
     				return result;
     
     			} finally {
    -				if (inputStream != null && closeableRegistry.unregisterCloseable(inputStream))
{
    +
    +				if (closeableRegistry.unregisterCloseable(inputStream)) {
     					inputStream.close();
     				}
     
    -				if (outputStream != null && closeableRegistry.unregisterCloseable(outputStream))
{
    +				if (closeableRegistry.unregisterCloseable(outputStream)) {
    --- End diff --
    
    Maybe instead of commenting this, we could rename `closeableRegistry` to `ongoingIoInteruptRegistry`
or `ongoingIoCancellingRegistry`


---

Mime
View raw message