flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #5202: [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT ...
Date Wed, 10 Jan 2018 14:16:22 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5202#discussion_r160687024
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/FunctionGenerator.scala
---
    @@ -414,6 +414,34 @@ object FunctionGenerator {
         DOUBLE_TYPE_INFO,
         BuiltInMethods.LOG_WITH_BASE)
     
    +  addSqlFunctionMethod(
    --- End diff --
    
    Shift operations are core binary operators. I would not add them here but in `ScalarOperators`.
Maybe we can already reuse `generateArithmeticOperator`.


---

Mime
View raw message