flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StefanRRichter <...@git.apache.org>
Subject [GitHub] flink pull request #5323: [FLINK-8441] [State Backend] [RocksDB] change Rock...
Date Mon, 22 Jan 2018 10:35:09 GMT
Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5323#discussion_r162898798
  
    --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBListState.java
---
    @@ -202,13 +206,17 @@ public void addAll(List<V> values) throws Exception {
     	private byte[] getPreMergedValue(List<V> values) throws IOException {
     		DataOutputViewStreamWrapper out = new DataOutputViewStreamWrapper(keySerializationStream);
     
    -		List<byte[]> bytes = new ArrayList<>(values.size());
    +		keySerializationStream.reset();
    +		byte first = 0;
    --- End diff --
    
    I think `boolean` is a more appropriate type.


---

Mime
View raw message