flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #5301: [FLINK-8267] [Kinesis Connector] update Kinesis Pr...
Date Mon, 22 Jan 2018 10:57:51 GMT
Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5301#discussion_r162904042
  
    --- Diff: docs/dev/connectors/kinesis.md ---
    @@ -271,9 +271,9 @@ For the monitoring to work, the user accessing the stream needs access
to the Cl
     {% highlight java %}
     Properties producerConfig = new Properties();
     // Required configs
    -producerConfig.put(AWSConfigConstants.AWS_REGION, "us-east-1");
     producerConfig.put(AWSConfigConstants.AWS_ACCESS_KEY_ID, "aws_access_key_id");
     producerConfig.put(AWSConfigConstants.AWS_SECRET_ACCESS_KEY, "aws_secret_access_key");
    +producerConfig.put("Region", "us-east-1");
    --- End diff --
    
    Is the "Region" string defined in some KPL class, e.g. `XXConstants`?
    If yes, maybe we should just demonstrate that class.
    That would make it more clear that the KPL configuration keys are directly supported.


---

Mime
View raw message