flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink issue #5328: [hotfix][codestyle] Refactor equals for StreamRecord
Date Mon, 22 Jan 2018 11:13:07 GMT
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5328
  
    Thank you joining the Flink community and contributing.
    
    Considering this specific change: I would like to _not_ merge this change.
    
    There was nothing wrong with the original code - this is a cosmetic change that does not
actually change anything significant. I personally would like to encourage not doing such
changes, because a project can easily get into a situation where committers spend a significant
amount of time formatting code and style back and forth rather than working on issues for
noticeable improvements.
    
    I would encourage you to look at the "how to contribute" page, which describes how to
find interesting issues for new contributions.


---

Mime
View raw message