flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #5240: [FLINK-8240] [table] Create unified interfaces to ...
Date Thu, 25 Jan 2018 14:56:12 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5240#discussion_r163865339
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/TableSourceDescriptor.scala
---
    @@ -0,0 +1,66 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.descriptors
    +
    +import org.apache.flink.table.descriptors.DescriptorUtils.statistics
    +import org.apache.flink.table.plan.stats.TableStats
    +
    +import scala.collection.JavaConverters._
    +
    +/**
    +  * Common class for all descriptors describing a table source.
    +  */
    +abstract class TableSourceDescriptor extends Descriptor {
    +
    +  protected var schemaDescriptor: Option[Schema] = None
    +  protected var connectorDescriptor: Option[ConnectorDescriptor] = None
    +  protected var encodingDescriptor: Option[EncodingDescriptor] = None
    +  protected var proctimeDescriptor: Option[Proctime] = None
    +  protected var rowtimeDescriptor: Option[Rowtime] = None
    +  protected var statisticsDescriptor: Option[Statistics] = None
    +  protected var metaDescriptor: Option[Metadata] = None
    +
    --- End diff --
    
    I added this functionality to the `Schema` descriptor.


---

Mime
View raw message