flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #5240: [FLINK-8240] [table] Create unified interfaces to ...
Date Thu, 25 Jan 2018 14:59:49 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5240#discussion_r163866463
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSourceFactory.scala
---
    @@ -0,0 +1,53 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.sources
    +
    +import java.util
    +
    +/**
    +  * A factory to create a [[TableSource]]. This factory is used with Java's Service Provider
    +  * Interfaces (SPI) for discovering. A factory is called with a set of normalized properties
that
    +  * describe the desired table source. The factory allows for matching to the given set
of
    +  * properties and creating a configured [[TableSource]] accordingly.
    +  *
    +  * Classes that implement this interface need to be added to the
    +  * "META_INF/services/org.apache.flink.table.sources.TableSourceFactory' file of a JAR
file in
    --- End diff --
    
    No, any JAR file can be used. We use similar functionality for the Flink file systems.
For example, we simply need to add a file to 
     `META_INF/services/org.apache.flink.table.sources.TableSourceFactory` into the Kafka
connector jar. The Java Service Provider Interfaces do the rest for us.


---

Mime
View raw message