flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #5308: [FLINK-8449] [flip6] Extend OnCompletionActions to...
Date Thu, 25 Jan 2018 15:33:47 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5308#discussion_r163877071
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
---
    @@ -1701,40 +1705,4 @@ void notifyExecutionChange(
     			}
     		}
     	}
    -
    -	@Override
    -	public ArchivedExecutionGraph archive() {
    --- End diff --
    
    I think it's better that the `ExecutionGraph` does not know about the `ArchivedExecutionGraph`
because the coupling should be vice versa.


---

Mime
View raw message