flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #5347: [FLINK-8492][table] Fix calc cost bug
Date Thu, 25 Jan 2018 15:57:23 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5347#discussion_r163879206
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonCalc.scala
---
    @@ -141,6 +143,7 @@ trait CommonCalc {
       }
     
       private[flink] def computeSelfCost(
    +      rexBuilder: RexBuilder,
    --- End diff --
    
    We don't need the `RexBuilder`


---

Mime
View raw message