flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From EronWright <...@git.apache.org>
Subject [GitHub] flink pull request #5307: [FLINK-8431] [mesos] Allow to specify # GPUs for T...
Date Mon, 29 Jan 2018 18:58:40 GMT
Github user EronWright commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5307#discussion_r164529293
  
    --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParameters.java
---
    @@ -238,6 +254,12 @@ public static MesosTaskManagerParameters create(Configuration flinkConfig)
{
     			cpus = Math.max(containeredParameters.numSlots(), 1.0);
     		}
     
    +		double gpus = Math.floor(flinkConfig.getDouble(MESOS_RM_TASKS_GPUS, 0.0));
    --- End diff --
    
    My feedback was similar, we could simply parse as an integer. The value must be an integer
due to a limitation in Mesos.  But the present solution seemed OK.


---

Mime
View raw message