flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tweise <...@git.apache.org>
Subject [GitHub] flink pull request #5393: [FLINK-8516] Allow for custom hash function for sh...
Date Wed, 31 Jan 2018 04:50:58 GMT
Github user tweise commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5393#discussion_r164952695
  
    --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
    @@ -93,6 +93,12 @@
     	/** User supplied deserialization schema to convert Kinesis byte messages to Flink objects.
*/
     	private final KinesisDeserializationSchema<T> deserializer;
     
    +	/**
    +	 * The function that determines which subtask a shard should be assigned to.
    +	 */
    +	// TODO: instead of the property, use a factory method that would allow subclass to
access source context?
    --- End diff --
    
    createFn(...) that will allow the function to be created with access to runtime context
(like the number of subtasks), and then change the fn signature to only take shard metadata
as parameter. Subclasses can override createFn, instead of having the property.


---

Mime
View raw message