flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #5269: [FLINK-6004] [kinesis] Allow FlinkKinesisConsumer ...
Date Wed, 31 Jan 2018 12:39:04 GMT
Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5269#discussion_r165039352
  
    --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
---
    @@ -484,7 +484,10 @@ protected Properties getConsumerConfiguration() {
     	 */
     	protected final void emitRecordAndUpdateState(T record, long recordTimestamp, int shardStateIndex,
SequenceNumber lastSequenceNumber) {
     		synchronized (checkpointLock) {
    -			sourceContext.collectWithTimestamp(record, recordTimestamp);
    +			if (record != null) {
    +				sourceContext.collectWithTimestamp(record, recordTimestamp);
    --- End diff --
    
    We currently do not have a log for that.
    I'll add a warning log if the record is null.


---

Mime
View raw message