flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #5367: [FLINK-7923][Table API & SQL] Support field access...
Date Wed, 31 Jan 2018 12:42:38 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5367#discussion_r165039357
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarOperators.scala
---
    @@ -984,6 +987,63 @@ object ScalarOperators {
         }
       }
     
    +  def generateDot(codeGenerator: CodeGenerator,
    --- End diff --
    
    I think this method is not really necessary. We already have logic for accessing composite
types (see `visitFieldAccess()`). Maybe we just have to make the methods there a bit more
generic.


---

Mime
View raw message