flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twalthr <...@git.apache.org>
Subject [GitHub] flink pull request #5367: [FLINK-7923][Table API & SQL] Support field access...
Date Wed, 31 Jan 2018 12:42:38 GMT
Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5367#discussion_r165038256
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/CalcTest.scala
---
    @@ -0,0 +1,47 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.table.api.stream.sql
    +
    +import org.apache.flink.api.scala._
    +import org.apache.flink.table.api.scala._
    +import org.apache.flink.table.utils.TableTestBase
    +import org.apache.flink.table.utils.TableTestUtil._
    +import org.junit.Test
    +
    +class CalcTest  extends TableTestBase {
    +
    +  @Test
    +  def testArrayElement(): Unit = {
    +    val util = streamTestUtil()
    +    util.addTable[(Long, Array[(String, Int)])]("MyTable", 'a, 'b)
    +
    +    val expected = unaryNode(
    +      "DataStreamCalc",
    +      streamTableNode(0),
    +      term("select",
    +        "a",
    +        "DOT(ITEM(b, 1), '_1') AS b11"
    --- End diff --
    
    Actually we don't need a full table test for this. As it only tests a scalar operation.
Can you move the test to `CompositeAccessTest` and test it for all APIs.


---

Mime
View raw message