flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #5335: (master) [FLINK-8419] [kafka] Register metrics for...
Date Wed, 31 Jan 2018 13:07:10 GMT
Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5335#discussion_r165045598
  
    --- Diff: flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/Kafka09Fetcher.java
---
    @@ -95,21 +95,19 @@ public Kafka09Fetcher(
     				watermarksPunctuated,
     				processingTimeProvider,
     				autoWatermarkInterval,
    -				userCodeClassLoader,
    +				userCodeClassLoader.getParent(),
    +				consumerMetricGroup,
     				useMetrics);
     
     		this.deserializer = deserializer;
     		this.handover = new Handover();
     
    -		final MetricGroup kafkaMetricGroup = metricGroup.addGroup(KAFKA_CONSUMER_METRICS_GROUP);
    -		addOffsetStateGauge(kafkaMetricGroup);
    -
     		this.consumerThread = new KafkaConsumerThread(
     				LOG,
     				handover,
     				kafkaProperties,
     				unassignedPartitionsQueue,
    -				kafkaMetricGroup,
    +				subtaskMetricGroup, // TODO: the thread should expose Kafka-shipped metrics through
the consumer metric group, not subtask metric group
    --- End diff --
    
    Will address this as discussed in #5336, and then merge this.


---

Mime
View raw message