flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6206) As an Engineer, I want task state transition log to be warn/error for FAILURE scenarios
Date Mon, 08 Jan 2018 14:16:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316384#comment-16316384
] 

ASF GitHub Bot commented on FLINK-6206:
---------------------------------------

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/5235
  
    This PR isn't addressing the original intent. The JIRA is about logging failure state
transitions (like RUNNING -> FAILING) as WARN/ERROR, not all state transitions.


> As an Engineer, I want task state transition log to be warn/error for FAILURE scenarios
> ---------------------------------------------------------------------------------------
>
>                 Key: FLINK-6206
>                 URL: https://issues.apache.org/jira/browse/FLINK-6206
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.2.0
>            Reporter: Dan Bress
>            Priority: Critical
>
> If a task fails due to an exception, I would like that to be logged at a warn or an error
level.  currently its info
> {code}
> private boolean transitionState(ExecutionState currentState, ExecutionState newState,
Throwable cause) {
> 		if (STATE_UPDATER.compareAndSet(this, currentState, newState)) {
> 			if (cause == null) {
> 				LOG.info("{} ({}) switched from {} to {}.", taskNameWithSubtask, executionId, currentState,
newState);
> 			} else {
> 				LOG.info("{} ({}) switched from {} to {}.", taskNameWithSubtask, executionId, currentState,
newState, cause);
> 			}
> 			return true;
> 		} else {
> 			return false;
> 		}
> 	}
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message