flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7511) Remove dead code after dropping backward compatibility with <=1.2
Date Mon, 15 Jan 2018 11:54:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326168#comment-16326168
] 

ASF GitHub Bot commented on FLINK-7511:
---------------------------------------

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4587#discussion_r161497658
  
    --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/AndFilterFunction.java
---
    @@ -1,55 +0,0 @@
    -/*
    - * Licensed to the Apache Software Foundation (ASF) under one
    - * or more contributor license agreements.  See the NOTICE file
    - * distributed with this work for additional information
    - * regarding copyright ownership.  The ASF licenses this file
    - * to you under the Apache License, Version 2.0 (the
    - * "License"); you may not use this file except in compliance
    - * with the License.  You may obtain a copy of the License at
    - *
    - *     http://www.apache.org/licenses/LICENSE-2.0
    - *
    - * Unless required by applicable law or agreed to in writing, software
    - * distributed under the License is distributed on an "AS IS" BASIS,
    - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    - * See the License for the specific language governing permissions and
    - * limitations under the License.
    - */
    -
    -package org.apache.flink.cep.pattern;
    -
    -import org.apache.flink.api.common.functions.FilterFunction;
    -
    -/**
    - * A filter function which combines two filter functions with a logical and. Thus, the
filter
    - * function only returns true, iff both filters return true.
    - *
    - * @param <T> Type of the element to filter
    - * @deprecated This is only used when migrating from an older Flink version.
    - * Use the {@link org.apache.flink.cep.pattern.conditions.AndCondition} instead.
    - */
    -@Deprecated
    -public class AndFilterFunction<T> implements FilterFunction<T> {
    --- End diff --
    
    Wouldn't it be better to have those conditions tested explicitly? And what about or/subtype
conditions? Are they covered as well?


> Remove dead code after dropping backward compatibility with <=1.2
> -----------------------------------------------------------------
>
>                 Key: FLINK-7511
>                 URL: https://issues.apache.org/jira/browse/FLINK-7511
>             Project: Flink
>          Issue Type: Improvement
>          Components: CEP
>    Affects Versions: 1.4.0
>            Reporter: Dawid Wysakowicz
>            Assignee: Dawid Wysakowicz
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message