flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7923) SQL parser exception when accessing subfields of a Composite element in an Object Array type column
Date Wed, 31 Jan 2018 12:43:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346757#comment-16346757
] 

ASF GitHub Bot commented on FLINK-7923:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5367#discussion_r165039357
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarOperators.scala
---
    @@ -984,6 +987,63 @@ object ScalarOperators {
         }
       }
     
    +  def generateDot(codeGenerator: CodeGenerator,
    --- End diff --
    
    I think this method is not really necessary. We already have logic for accessing composite
types (see `visitFieldAccess()`). Maybe we just have to make the methods there a bit more
generic.


> SQL parser exception when accessing subfields of a Composite element in an Object Array
type column
> ---------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-7923
>                 URL: https://issues.apache.org/jira/browse/FLINK-7923
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API &amp; SQL
>    Affects Versions: 1.4.0
>            Reporter: Rong Rong
>            Assignee: Shuyi Chen
>            Priority: Major
>
> Access type such as:
> {code:SQL}
> SELECT 
>   a[1].f0 
> FROM 
>   MyTable
> {code}
> will cause problem. 
> See following test sample for more details:
> https://github.com/walterddr/flink/commit/03c93bcb0fb30bd2d327e35b5e244322d449b06a



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message