flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8162) Kinesis Connector to report millisBehindLatest metric
Date Mon, 08 Jan 2018 12:29:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316212#comment-16316212
] 

ASF GitHub Bot commented on FLINK-8162:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5182#discussion_r160132062
  
    --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
---
    @@ -542,6 +545,16 @@ public int registerNewSubscribedShardState(KinesisStreamShardState
newSubscribed
     		}
     	}
     
    +	/**
    +	 * Registers a metric group associated with the shard id of the provided {@link KinesisStreamShardState
shardState}.
    +	 */
    +	private MetricGroup buildMetricGroupForShard(KinesisStreamShardState shardState) {
    +		return runtimeContext
    +			.getMetricGroup()
    +			.addGroup("Kinesis")
    +			.addGroup("shard_id", shardState.getStreamShardHandle().getShard().getShardId());
    --- End diff --
    
    Is the underscore important? Would prefer shardId for consistency.


> Kinesis Connector to report millisBehindLatest metric
> -----------------------------------------------------
>
>                 Key: FLINK-8162
>                 URL: https://issues.apache.org/jira/browse/FLINK-8162
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kinesis Connector
>            Reporter: Cristian
>            Priority: Minor
>              Labels: kinesis
>             Fix For: 1.5.0
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> When reading from Kinesis streams, one of the most valuable metrics is "MillisBehindLatest"
(see https://github.com/aws/aws-sdk-java/blob/25f0821f69bf94ec456f602f2b83ea2b0ca15643/aws-java-sdk-kinesis/src/main/java/com/amazonaws/services/kinesis/model/GetRecordsResult.java#L187-L201).
> Flink should use its metrics mechanism to report this value as a gauge, tagging it with
the shard id.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message