flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8234) Cache JobExecutionResult from finished JobManagerRunners
Date Mon, 08 Jan 2018 10:37:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316057#comment-16316057
] 

ASF GitHub Bot commented on FLINK-8234:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5184#discussion_r159603034
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
    @@ -357,6 +360,31 @@ public void start() throws Exception {
     		return CompletableFuture.completedFuture(jobManagerServices.blobServer.getPort());
     	}
     
    +	@Override
    +	public CompletableFuture<JobExecutionResult> getJobExecutionResult(
    +			final JobID jobId,
    +			final Time timeout) {
    +
    +		final JobExecutionResult jobExecutionResult = jobExecutionResultCache.get(jobId);
    +		if (jobExecutionResult == null) {
    +			return FutureUtils.completedExceptionally(new JobExecutionResultNotFoundException(jobId));
    +		} else {
    +			return CompletableFuture.completedFuture(jobExecutionResult);
    +		}
    +	}
    +
    +	@Override
    +	public CompletableFuture<Boolean> isJobExecutionResultPresent(
    --- End diff --
    
    Shall we maybe rename this method into `isJobExecutionResultDone`


> Cache JobExecutionResult from finished JobManagerRunners
> --------------------------------------------------------
>
>                 Key: FLINK-8234
>                 URL: https://issues.apache.org/jira/browse/FLINK-8234
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Gary Yao
>            Priority: Blocker
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> In order to serve the {{JobExecutionResults}} we have to cache them in the {{Dispatcher}}
after the {{JobManagerRunner}} has finished. The cache should have a configurable size and
should periodically clean up stale entries in order to avoid memory exhaustion.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message