flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8306) FlinkKafkaConsumerBaseTest has invalid mocks on final methods
Date Mon, 08 Jan 2018 10:58:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316106#comment-16316106
] 

ASF GitHub Bot commented on FLINK-8306:
---------------------------------------

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5200#discussion_r160105955
  
    --- Diff: flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/AbstractFetcher.java
---
    @@ -51,7 +50,7 @@
      *            the Flink data streams.
      * @param <KPH> The type of topic/partition identifier used by Kafka in the specific
version.
      */
    -public abstract class AbstractFetcher<T, KPH> {
    +public abstract class AbstractFetcher<T, KPH> implements KafkaOffsetCommitter {
    --- End diff --
    
    Maybe use composition instead of inheritance here? `AbstractFetcher` as "being a" `KafkaOffsetCommitter`
do not make sense to me when I say it out laud, while `AbstractFetcher` "having a"  `KafkaOffsetCommitter`
sounds better.


> FlinkKafkaConsumerBaseTest has invalid mocks on final methods
> -------------------------------------------------------------
>
>                 Key: FLINK-8306
>                 URL: https://issues.apache.org/jira/browse/FLINK-8306
>             Project: Flink
>          Issue Type: Bug
>          Components: Kafka Connector, Tests
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Tzu-Li (Gordon) Tai
>            Priority: Critical
>             Fix For: 1.5.0, 1.4.1
>
>
> The {{FlinkKafkaConsumerBaseTest}} has invalid mocks on a final {{AbstractFetcher::commitInternalOffsetsToKafka(...)}}
method. While an easy fix would be to simply make that method non-final, that is not ideal
since it would be best that the method is left final to prevent overrides in subclasses.
> This suggests that offset committing functionality is too tightly coupled with the {{AbstractFetcher}},
making it hard to perform concise tests to verify offset committing.
> I suggest that we decouple record fetching and offset committing as separate services
behind different interfaces. We should introduce a new interface, say {{KafkaOffsetCommitter}},
and test against that instead. Initially, we can simply let {{AbstractFetcher}} implement
{{KafkaOffsetCommitter}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message