flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8328) Pull Yarn ApplicationStatus polling out of YarnClusterClient
Date Wed, 10 Jan 2018 13:22:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320215#comment-16320215
] 

ASF GitHub Bot commented on FLINK-8328:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5215#discussion_r160674117
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java
---
    @@ -660,7 +570,25 @@ public int run(
     					"yarn application -kill " + applicationId.getOpt());
     				yarnCluster.disconnect();
     			} else {
    -				runInteractiveCli(yarnCluster, true);
    +				ScheduledThreadPoolExecutor scheduledExecutorService = new ScheduledThreadPoolExecutor(1);
    --- End diff --
    
    Yes it could be. That way, however, we support that we can use an arbitrary executor which
is available (as you've mentioned for tests). Since refactoring wouldn't add much value, I'll
keep it like this.


> Pull Yarn ApplicationStatus polling out of YarnClusterClient
> ------------------------------------------------------------
>
>                 Key: FLINK-8328
>                 URL: https://issues.apache.org/jira/browse/FLINK-8328
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Client
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> In order to make the {{FlinkYarnSessionCli}} work with Flip-6, we have to pull the Yarn
{{ApplicationStatus}} polling out of the {{YarnClusterClient}}. I propose to introduce a dedicated
{{YarnApplicationStatusMonitor}}. This has also the benefit of separating concerns better.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message