flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8333) Split command options from deployment options in CliFrontend
Date Wed, 03 Jan 2018 14:56:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16309756#comment-16309756
] 

ASF GitHub Bot commented on FLINK-8333:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5220#discussion_r159435504
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
    @@ -292,20 +267,14 @@ protected int run(String[] args) {
     	 *
     	 * @param args Command line arguments for the info action.
     	 */
    -	protected int info(String[] args) {
    +	protected int info(String[] args) throws CliArgsException, FileNotFoundException, ProgramInvocationException
{
     		LOG.info("Running 'info' command.");
     
    -		// Parse command line options
    -		InfoOptions options;
    -		try {
    -			options = CliFrontendParser.parseInfoCommand(args);
    --- End diff --
    
    `CliFrontendParser.parseInfoCommand()` is no longer in use. Can be deleted.
      


> Split command options from deployment options in CliFrontend
> ------------------------------------------------------------
>
>                 Key: FLINK-8333
>                 URL: https://issues.apache.org/jira/browse/FLINK-8333
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Client
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> In order to better support different {{CustomCommandLines}} we should split the command
and deployment option parsing in the {{CliFrontend}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message