flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8333) Split command options from deployment options in CliFrontend
Date Wed, 03 Jan 2018 14:56:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16309760#comment-16309760
] 

ASF GitHub Bot commented on FLINK-8333:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5220#discussion_r159430427
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
    @@ -587,9 +526,7 @@ protected int cancel(String[] args) {
     			try {
     				jobId = new JobID(StringUtils.hexStringToByte(jobIdString));
     			} catch (Exception e) {
    -				LOG.error("Error: The value for the Job ID is not a valid ID.");
    -				System.out.println("Error: The value for the Job ID is not a valid ID.");
    -				return 1;
    +				throw new CliArgsException("The value for the JobID is not a valid ID: " + e.getMessage());
    --- End diff --
    
    Maybe log the input value as well
    ```
    	try {
    			new JobID(StringUtils.hexStringToByte("dea84ec368d886f1638c01447ec6951"));
    		} catch (Exception e) {
    			throw new CliArgsException("The value for the JobID is not a valid ID: " + e.getMessage());
    		}
    ```
    message is:
    ```
    The value for the JobID is not a valid ID: Argument bytes must by an array of 16 bytes
    ```
    
    Also, this piece of code is duplicated.


> Split command options from deployment options in CliFrontend
> ------------------------------------------------------------
>
>                 Key: FLINK-8333
>                 URL: https://issues.apache.org/jira/browse/FLINK-8333
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Client
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> In order to better support different {{CustomCommandLines}} we should split the command
and deployment option parsing in the {{CliFrontend}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message