flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8338) Make CustomCommandLines non static in CliFrontend
Date Thu, 04 Jan 2018 13:26:05 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311325#comment-16311325
] 

ASF GitHub Bot commented on FLINK-8338:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5224#discussion_r159451928
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
---
    @@ -391,35 +353,22 @@ public static void printHelpForSavepoint() {
     		formatter.setSyntaxPrefix("  \"savepoint\" action options:");
     		formatter.printHelp(" ", getSavepointOptionsWithoutDeprecatedOptions(new Options()));
     
    -		printCustomCliOptions(formatter, false);
    +		printCustomCliOptions(customCommandLines, formatter, false);
     
     		System.out.println();
     	}
     
    -	/**
    -	 * Adds custom cli options.
    -	 * @param options The options to add options to
    -	 * @param runOptions Whether to include run options
    -	 * @return Options with additions
    -	 */
    -	private static Options addCustomCliOptions(Options options, boolean runOptions) {
    -		for (CustomCommandLine cli: CliFrontend.getCustomCommandLineList()) {
    -			cli.addGeneralOptions(options);
    -			if (runOptions) {
    -				cli.addRunOptions(options);
    -			}
    -		}
    -		return options;
    -	}
    -
     	/**
     	 * Prints custom cli options.
     	 * @param formatter The formatter to use for printing
     	 * @param runOptions True if the run options should be printed, False to print only
general options
     	 */
    -	private static void printCustomCliOptions(HelpFormatter formatter, boolean runOptions)
{
    +	private static void printCustomCliOptions(
    +		Collection<CustomCommandLine<?>> customCommandLines,
    --- End diff --
    
    nit: indentation


> Make CustomCommandLines non static in CliFrontend
> -------------------------------------------------
>
>                 Key: FLINK-8338
>                 URL: https://issues.apache.org/jira/browse/FLINK-8338
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Client
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> For better testability and maintainability we should make the {{CustomCommandLine}} registration
non-static in {{CliFrontend}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message