flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8342) Remove ClusterClient generic type parameter from ClusterDescriptor
Date Mon, 08 Jan 2018 10:54:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316099#comment-16316099
] 

ASF GitHub Bot commented on FLINK-8342:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5228#discussion_r160115439
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
    @@ -99,7 +99,7 @@
     /**
      * The descriptor with deployment information for spawning or resuming a {@link YarnClusterClient}.
      */
    -public abstract class AbstractYarnClusterDescriptor implements ClusterDescriptor<YarnClusterClient>
{
    +public abstract class AbstractYarnClusterDescriptor implements ClusterDescriptor {
     	private static final Logger LOG = LoggerFactory.getLogger(YarnClusterDescriptor.class);
    --- End diff --
    
    Wrong logger used?


> Remove ClusterClient generic type parameter from ClusterDescriptor
> ------------------------------------------------------------------
>
>                 Key: FLINK-8342
>                 URL: https://issues.apache.org/jira/browse/FLINK-8342
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Client
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> The {{ClusterDescriptor}} should not specialize the returned {{ClusterClient}} type in
order to develop code which can work with all {{ClusterDescriptors}} and {{ClusterClients}}.
Therefore, I propose to remove the generic type parameter from {{ClusterDescriptor}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message