flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8344) Add support for HA to RestClusterClient
Date Tue, 23 Jan 2018 07:25:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16335437#comment-16335437
] 

ASF GitHub Bot commented on FLINK-8344:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5312#discussion_r163160672
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorEndpoint.java
---
    @@ -144,6 +154,15 @@ public WebMonitorEndpoint(
     			metricQueryServiceRetriever,
     			executor,
     			restConfiguration.getTimeout());
    +
    +		this.leaderElectionService = Preconditions.checkNotNull(leaderElectionService);
    +		this.fatalErrorHandler = Preconditions.checkNotNull(fatalErrorHandler);
    +	}
    +
    +	@Override
    +	public void start() throws Exception {
    +		super.start();
    +		leaderElectionService.start(this);
    --- End diff --
    
    Added 
    ```
    		try {
    			leaderElectionService.stop();
    		} catch (Exception e) {
    			log.warn("Error while stopping leaderElectionService", e);
    		}
    ```
    to `shutdown` hook


> Add support for HA to RestClusterClient
> ---------------------------------------
>
>                 Key: FLINK-8344
>                 URL: https://issues.apache.org/jira/browse/FLINK-8344
>             Project: Flink
>          Issue Type: Improvement
>          Components: Client
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Gary Yao
>            Priority: Major
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> The {{RestClusterClient}} must be able to deal with changing JobMasters in case of HA.
We have to add functionality to reconnect to a newly elected leader in case of HA.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message