flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8344) Add support for HA to RestClusterClient
Date Fri, 26 Jan 2018 10:13:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340842#comment-16340842
] 

ASF GitHub Bot commented on FLINK-8344:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5312#discussion_r164074605
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClientConfiguration.java
---
    @@ -19,60 +19,73 @@
     package org.apache.flink.client.program.rest;
     
     import org.apache.flink.configuration.Configuration;
    -import org.apache.flink.configuration.JobManagerOptions;
     import org.apache.flink.configuration.RestOptions;
     import org.apache.flink.runtime.rest.RestClientConfiguration;
     import org.apache.flink.util.ConfigurationException;
     import org.apache.flink.util.Preconditions;
     
    +import static org.apache.flink.util.Preconditions.checkArgument;
    +
     /**
      * A configuration object for {@link RestClusterClient}s.
      */
     public final class RestClusterClientConfiguration {
     
    -	private final String blobServerAddress;
    -
     	private final RestClientConfiguration restClientConfiguration;
     
    -	private final String restServerAddress;
    +	private final int awaitLeaderTimeout;
    +
    +	private final int retryMaxAttempts;
     
    -	private final int restServerPort;
    +	private final int retryDelay;
     
     	private RestClusterClientConfiguration(
    -			String blobServerAddress,
    -			RestClientConfiguration endpointConfiguration,
    -			String restServerAddress,
    -			int restServerPort) {
    -		this.blobServerAddress = Preconditions.checkNotNull(blobServerAddress);
    +			final RestClientConfiguration endpointConfiguration,
    +			final int awaitLeaderTimeout,
    +			final int retryMaxAttempts,
    +			final int retryDelay) {
    --- End diff --
    
    changed all delays and timeouts to `long`


> Add support for HA to RestClusterClient
> ---------------------------------------
>
>                 Key: FLINK-8344
>                 URL: https://issues.apache.org/jira/browse/FLINK-8344
>             Project: Flink
>          Issue Type: Improvement
>          Components: Client
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Gary Yao
>            Priority: Major
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> The {{RestClusterClient}} must be able to deal with changing JobMasters in case of HA.
We have to add functionality to reconnect to a newly elected leader in case of HA.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message