flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8345) Iterate over keyed state on broadcast side of connect with broadcast.
Date Thu, 25 Jan 2018 19:26:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16339694#comment-16339694
] 

ASF GitHub Bot commented on FLINK-8345:
---------------------------------------

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5230#discussion_r163936903
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/OperatorStateHandle.java
---
    @@ -36,8 +36,9 @@
     	 * The modes that determine how an {@link OperatorStateHandle} is assigned to tasks
during restore.
     	 */
     	public enum Mode {
    -		SPLIT_DISTRIBUTE, // The operator state partitions in the state handle are split and
distributed to one task each.
    -		BROADCAST // The operator state partitions are broadcast to all task.
    +		SPLIT_DISTRIBUTE,	// The operator state partitions in the state handle are split and
distributed to one task each.
    +		BROADCAST,			// The operator state partitions are broadcasted to all tasks.
    --- End diff --
    
    Maybe naming this mode `BROADCAST` was not ideal in the first place (perhaps `UNION`,
to correspond to the API name, would be better). 
    Looking at the name / comments alone between `BROADCAST` and `UNIFORM_BROADCAST` is actually
quite confusing.


> Iterate over keyed state on broadcast side of connect with broadcast.
> ---------------------------------------------------------------------
>
>                 Key: FLINK-8345
>                 URL: https://issues.apache.org/jira/browse/FLINK-8345
>             Project: Flink
>          Issue Type: New Feature
>          Components: Streaming
>    Affects Versions: 1.5.0
>            Reporter: Kostas Kloudas
>            Assignee: Kostas Kloudas
>            Priority: Major
>             Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message