flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8441) serialize values and value separator directly to stream in RocksDBListState
Date Mon, 22 Jan 2018 10:36:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334118#comment-16334118
] 

ASF GitHub Bot commented on FLINK-8441:
---------------------------------------

Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5323#discussion_r162898798
  
    --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBListState.java
---
    @@ -202,13 +206,17 @@ public void addAll(List<V> values) throws Exception {
     	private byte[] getPreMergedValue(List<V> values) throws IOException {
     		DataOutputViewStreamWrapper out = new DataOutputViewStreamWrapper(keySerializationStream);
     
    -		List<byte[]> bytes = new ArrayList<>(values.size());
    +		keySerializationStream.reset();
    +		byte first = 0;
    --- End diff --
    
    I think `boolean` is a more appropriate type.


> serialize values and value separator directly to stream in RocksDBListState
> ---------------------------------------------------------------------------
>
>                 Key: FLINK-8441
>                 URL: https://issues.apache.org/jira/browse/FLINK-8441
>             Project: Flink
>          Issue Type: Improvement
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.5.0
>            Reporter: Bowen Li
>            Assignee: Bowen Li
>            Priority: Major
>             Fix For: 1.5.0
>
>
> In \{{RocksDBListState#getPreMergedValue}}, we could probably serialize values and value
separator directly into {{keySerializationStream}}.
> We tried once, it didn't work out. Let's try one more time



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message