flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8449) Extend OnCompletionActions to receive AccessExecutionGraph
Date Thu, 25 Jan 2018 15:34:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16339383#comment-16339383
] 

ASF GitHub Bot commented on FLINK-8449:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5308#discussion_r163877071
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionGraph.java
---
    @@ -1701,40 +1705,4 @@ void notifyExecutionChange(
     			}
     		}
     	}
    -
    -	@Override
    -	public ArchivedExecutionGraph archive() {
    --- End diff --
    
    I think it's better that the `ExecutionGraph` does not know about the `ArchivedExecutionGraph`
because the coupling should be vice versa.


> Extend OnCompletionActions to receive AccessExecutionGraph
> ----------------------------------------------------------
>
>                 Key: FLINK-8449
>                 URL: https://issues.apache.org/jira/browse/FLINK-8449
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Major
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> The {{OnCompletionAction}} currently only receives the {{JobResult}} when the job terminates.
For further archiving of the {{ArchivedExecutionGraph}}, we should change this to {{AccessExecutionGraph}}.
The {{AccessExecutionGraph}} contains all the information to derive the {{JobResult}} and
additionally the information needed for serving information about completed jobs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message