flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StefanRRichter <...@git.apache.org>
Subject [GitHub] flink pull request #5256: [FLINK-8385] Fix exceptions in AbstractEventTimeWi...
Date Mon, 08 Jan 2018 10:39:41 GMT
GitHub user StefanRRichter opened a pull request:

    https://github.com/apache/flink/pull/5256

    [FLINK-8385] Fix exceptions in AbstractEventTimeWindowCheckpointingITCase

    ## What is the purpose of the change
    
    This change fixes two types of exceptions that I found when running `AbstractEventTimeWindowCheckpointingITCase`
in debug mode (see JIRA).
    
    ## Brief change log
    
      - *As a temporary fix for the first mentioned exception, we catch the `RejectedExecutionException`
and execute the `Runnable` directly.*
      - *Suppress expected `CancellationException` or `ExecutionException` when closing snapshot
future task.*
    
    ## Verifying this change
    
    This change is already covered by `AbstractEventTimeWindowCheckpointingITCase`. You should
no longer see the mentioned exceptions when running all concrete instances of the test.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (yes)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StefanRRichter/flink WIP

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5256.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5256
    
----
commit 72ee09e86205f2fc83f5247bf15c861b94af73cc
Author: Stefan Richter <s.richter@...>
Date:   2018-01-08T10:30:08Z

    [FLINK-8385] [checkpointing] Suppress logging of expected exception during snapshot cancellation.

commit e6f4c404c633d844c80341cc288b6bd4b89d8705
Author: Stefan Richter <s.richter@...>
Date:   2018-01-08T10:31:57Z

    [FLINK-8385] [checkpointing] Avoid RejectedExecutionException in SharedStateRegistry during
disposal from async Zookeeper calls.

----


---

Mime
View raw message