flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StefanRRichter <...@git.apache.org>
Subject [GitHub] flink pull request #5601: [FLINK-8818][yarn/s3][tests] harden YarnFileStageT...
Date Mon, 05 Mar 2018 11:06:48 GMT
Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5601#discussion_r172152959
  
    --- Diff: flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTest.java ---
    @@ -200,13 +201,23 @@ static void testCopyFromLocalRecursive(
     			while (targetFilesIterator.hasNext()) {
     				LocatedFileStatus targetFile = targetFilesIterator.next();
     
    -				try (FSDataInputStream in = targetFileSystem.open(targetFile.getPath())) {
    -					String absolutePathString = targetFile.getPath().toString();
    -					String relativePath = absolutePathString.substring(workDirPrefixLength);
    -					targetFiles.put(relativePath, in.readUTF());
    -
    -					assertEquals("extraneous data in file " + relativePath, -1, in.read());
    -				}
    +				int retries = 5;
    --- End diff --
    
    I wonder if this should be a magic number or better something that can be configured?


---

Mime
View raw message