flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From walterddr <...@git.apache.org>
Subject [GitHub] flink pull request #5638: [FLINK-6924][table]ADD LOG(X) supported in TableAP...
Date Sat, 10 Mar 2018 01:42:28 GMT
Github user walterddr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5638#discussion_r173606447
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
---
    @@ -1130,4 +1130,13 @@ object concat_ws {
       }
     }
     
    +object log {
    +  def apply(base: Expression, antilogarithm: Expression): Expression = {
    +    Log(base, antilogarithm)
    +  }
    +  def apply(antilogarithm: Expression): Expression = {
    +    new Log(antilogarithm)
    --- End diff --
    
    Is it just `new Ln(antilogarithm)`, we might be able to restructure them together?


---

Mime
View raw message