flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GJL <...@git.apache.org>
Subject [GitHub] flink pull request #5775: [FLINK-9099] Assign Execution to LogicalSlot when ...
Date Tue, 27 Mar 2018 19:24:16 GMT
Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5775#discussion_r177543886
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java
---
    @@ -659,7 +660,7 @@ public void disconnectResourceManager() {
     			.orTimeout(pendingRequest.getAllocatedSlotFuture(), allocationTimeout.toMilliseconds(),
TimeUnit.MILLISECONDS)
     			.whenCompleteAsync(
     				(AllocatedSlot ignored, Throwable throwable) -> {
    -					if (throwable != null) {
    +					if (throwable instanceof TimeoutException) {
    --- End diff --
    
    Are we not losing some information by swallowing other types of exceptions?


---

Mime
View raw message