flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GJL <...@git.apache.org>
Subject [GitHub] flink pull request #5775: [FLINK-9099] Assign Execution to LogicalSlot when ...
Date Tue, 27 Mar 2018 19:28:11 GMT
Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5775#discussion_r177544954
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphSchedulingTest.java
---
    @@ -465,6 +464,58 @@ public void testSchedulingOperationCancellationWhenCancel() throws
Exception {
     		assertThat(executionGraph.getTerminationFuture().get(), is(JobStatus.CANCELED));
     	}
     
    +	@Nonnull
    +	private TestingLogicalSlot createTestingSlot(@Nullable CompletableFuture<?> releaseFuture)
{
    --- End diff --
    
    nit: make static and move below:
    ```
        // ------------------------------------------------------------------------
    	//  Utilities
    	// ------------------------------------------------------------------------
    ```


---

Mime
View raw message