flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GJL <...@git.apache.org>
Subject [GitHub] flink pull request #5767: [FLINK-8887] Wait for JobMaster leader election in...
Date Wed, 28 Mar 2018 09:58:39 GMT
Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5767#discussion_r177696032
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/nonha/embedded/EmbeddedLeaderService.java
---
    @@ -440,28 +439,33 @@ public void run() {
     
     	private static class GrantLeadershipCall implements Runnable {
     
    -		private final LeaderContender contender;
    +		private final EmbeddedLeaderElectionService leaderCandidate;
     		private final UUID leaderSessionId;
     		private final Logger logger;
     
     		GrantLeadershipCall(
    -				LeaderContender contender,
    +				EmbeddedLeaderElectionService leaderCandidate,
    --- End diff --
    
    Why is this called `leaderCandidate` and not `leaderElectionService?


---

Mime
View raw message