flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GJL <...@git.apache.org>
Subject [GitHub] flink pull request #5774: [FLINK-9097] Fail fatally if job submission fails ...
Date Wed, 28 Mar 2018 12:48:46 GMT
Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5774#discussion_r177726769
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java
---
    @@ -507,19 +539,21 @@ private TestingDispatcher(
     				jobManagerMetricGroup,
     				metricQueryServicePath,
     				archivedExecutionGraphStore,
    -				new ExpectedJobIdJobManagerRunnerFactory(expectedJobId),
    +				jobManagerRunnerFactory,
     				fatalErrorHandler,
     				null);
     		}
     
    -		@Override
    -		public CompletableFuture<Acknowledge> submitJob(final JobGraph jobGraph, final
Time timeout) {
    -			final CompletableFuture<Acknowledge> submitJobFuture = super.submitJob(jobGraph,
timeout);
    -
    -			submitJobFuture.thenAccept(ignored -> submitJobLatch.countDown());
     
    -			return submitJobFuture;
    -		}
    +//
    +//		@Override
    --- End diff --
    
    delete commented code?


---

Mime
View raw message