flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kl0u <...@git.apache.org>
Subject [GitHub] flink pull request #5756: [FLINK-8813][flip6] Disallow PARALLELISM_AUTO_MAX ...
Date Wed, 28 Mar 2018 14:48:09 GMT
Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5756#discussion_r177775838
  
    --- Diff: flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterResource.java
---
    @@ -93,6 +93,10 @@ private MiniClusterResource(
     		this.enableClusterClient = enableClusterClient;
     	}
     
    +	public MiniClusterType getMiniClusterType() {
    --- End diff --
    
    Why not renaming it to sth like `isLegacyDeployment()` and return a `boolean` this will
also allow to make the `MiniClusterType` a private class which is also better pattern.


---

Mime
View raw message