flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-6924) ADD LOG(X) supported in TableAPI
Date Sat, 10 Mar 2018 01:43:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-6924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393949#comment-16393949
] 

ASF GitHub Bot commented on FLINK-6924:
---------------------------------------

Github user walterddr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5638#discussion_r173606447
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
---
    @@ -1130,4 +1130,13 @@ object concat_ws {
       }
     }
     
    +object log {
    +  def apply(base: Expression, antilogarithm: Expression): Expression = {
    +    Log(base, antilogarithm)
    +  }
    +  def apply(antilogarithm: Expression): Expression = {
    +    new Log(antilogarithm)
    --- End diff --
    
    Is it just `new Ln(antilogarithm)`, we might be able to restructure them together?


> ADD LOG(X) supported in TableAPI
> --------------------------------
>
>                 Key: FLINK-6924
>                 URL: https://issues.apache.org/jira/browse/FLINK-6924
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API &amp; SQL
>    Affects Versions: 1.4.0
>            Reporter: sunjincheng
>            Assignee: zjuwangg
>            Priority: Major
>              Labels: starter
>
> See FLINK-6891 for detail.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message