flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8037) Missing cast in integer arithmetic in TransactionalIdsGenerator#generateIdsToAbort
Date Thu, 01 Mar 2018 02:15:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381397#comment-16381397
] 

ASF GitHub Bot commented on FLINK-8037:
---------------------------------------

Github user tedyu commented on the issue:

    https://github.com/apache/flink/pull/5205
  
    Looks like the PR needs to be rebased.


> Missing cast in integer arithmetic in TransactionalIdsGenerator#generateIdsToAbort
> ----------------------------------------------------------------------------------
>
>                 Key: FLINK-8037
>                 URL: https://issues.apache.org/jira/browse/FLINK-8037
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Greg Hogan
>            Priority: Minor
>              Labels: kafka-connect
>
> {code}
>   public Set<String> generateIdsToAbort() {
>     Set<String> idsToAbort = new HashSet<>();
>     for (int i = 0; i < safeScaleDownFactor; i++) {
>       idsToAbort.addAll(generateIdsToUse(i * poolSize * totalNumberOfSubtasks));
> {code}
> The operands are integers where generateIdsToUse() expects long parameter.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message