flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "mingleizhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8687) MaterializedCollectStreamResult#retrievePage should take resultLock
Date Tue, 06 Mar 2018 06:51:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16387372#comment-16387372
] 

mingleizhang commented on FLINK-8687:
-------------------------------------

[~yuzhihong@gmail.com] Shouldn't we lock {{write}} situation ? means, also lock on {{CliTableResultView#updatePage}}.
If we do not do that, I think it is still encounter a multi-threads problem. 

> MaterializedCollectStreamResult#retrievePage should take resultLock
> -------------------------------------------------------------------
>
>                 Key: FLINK-8687
>                 URL: https://issues.apache.org/jira/browse/FLINK-8687
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: mingleizhang
>            Priority: Major
>
> Currently MaterializedCollectStreamResult#retrievePage checks page range and calls snapshot.subList()
without holding resultLock.
> {{resultLock}} should be taken.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message