flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8708) Unintended integer division in StandaloneThreadedGenerator
Date Wed, 28 Mar 2018 01:56:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416585#comment-16416585
] 

ASF GitHub Bot commented on FLINK-8708:
---------------------------------------

GitHub user yanghua opened a pull request:

    https://github.com/apache/flink/pull/5776

    [FLINK-8708] Unintended integer division in StandaloneThreadedGenerator

    ## What is the purpose of the change
    
    *This pull request fixed unintended integer division in StandaloneThreadedGenerator*
    
    ## Brief change log
    
      - *Fixed unintended integer division in StandaloneThreadedGenerator*
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes
/ **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yanghua/flink FLINK-8708

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5776.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5776
    
----
commit 68c602c53edc6afbf76efa51c9f41ffc4db5e343
Author: yanghua <yanghua1127@...>
Date:   2018-03-28T01:52:39Z

    [FLINK-8708] Unintended integer division in StandaloneThreadedGenerator

----


> Unintended integer division in StandaloneThreadedGenerator
> ----------------------------------------------------------
>
>                 Key: FLINK-8708
>                 URL: https://issues.apache.org/jira/browse/FLINK-8708
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: vinoyang
>            Priority: Minor
>
> In flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/statemachine/generator/StandaloneThreadedGenerator.java
:
> {code}
>         double factor = (ts - lastTimeStamp) / 1000;
> {code}
> Proper casting should be done before the integer division



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message