flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8799) Make AbstractYarnClusterDescriptor immutable
Date Fri, 02 Mar 2018 09:32:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383393#comment-16383393
] 

ASF GitHub Bot commented on FLINK-8799:
---------------------------------------

GitHub user yanghua opened a pull request:

    https://github.com/apache/flink/pull/5617

    [FLINK-8799][YARN] Make AbstractYarnClusterDescriptor immutable

    ## What is the purpose of the change
    
    *This pull request Make AbstractYarnClusterDescriptor immutable*
    
    
    ## Brief change log
    
      - *removed or closed some setter accessor in class `AbstractYarnClusterDescriptor`*
      - *deleted some set property code and replaced with adding option to `Configuration`
instance*
      - *fetch the config item from `Configuration` and init the field for `AbstractYarnClusterDescriptor`*
      - *add some config to `YarnConfigOptions`*
      - *fixed some old test cast and some new test case for refactored config properties*
    
    
    ## Verifying this change
    
    This change added tests and can be verified as follows:
    
      - *fixed some old test cast and some new test case for refactored config properties
such as flink jar path and name and so on*
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? ( no)
      - If yes, how is the feature documented? (not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yanghua/flink FLINK-8799

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5617.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5617
    
----
commit f04f8d68a0859923dcdba594ce22b5f420305df5
Author: vinoyang <vinoyang@...>
Date:   2018-03-02T09:22:54Z

    [FLINK-8799][YARN] Make AbstractYarnClusterDescriptor immutable

----


> Make AbstractYarnClusterDescriptor immutable
> --------------------------------------------
>
>                 Key: FLINK-8799
>                 URL: https://issues.apache.org/jira/browse/FLINK-8799
>             Project: Flink
>          Issue Type: Improvement
>          Components: YARN
>    Affects Versions: 1.5.0
>            Reporter: Gary Yao
>            Assignee: vinoyang
>            Priority: Major
>             Fix For: 1.6.0
>
>
> {{AbstractYarnClusterDescriptor}} should be made immutable. Currently, its internal configuration
is modified from different places which makes it difficult to reason about the code. For example,
it should not be possible to modify the {{zookeeperNamespace}} using a setter method. A user
of this class should be forced to provide all information prior to creating the instance,
e.g., by passing a {{org.apache.flink.configuration.Configuration}} object.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message