flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8810) Move end-to-end test scripts to end-to-end module
Date Thu, 01 Mar 2018 14:25:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382054#comment-16382054
] 

ASF GitHub Bot commented on FLINK-8810:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5612#discussion_r171572132
  
    --- Diff: flink-end-to-end-tests/run-pre-commit-tests.sh ---
    @@ -0,0 +1,98 @@
    +#!/usr/bin/env bash
    +################################################################################
    +#  Licensed to the Apache Software Foundation (ASF) under one
    +#  or more contributor license agreements.  See the NOTICE file
    +#  distributed with this work for additional information
    +#  regarding copyright ownership.  The ASF licenses this file
    +#  to you under the Apache License, Version 2.0 (the
    +#  "License"); you may not use this file except in compliance
    +#  with the License.  You may obtain a copy of the License at
    +#
    +#      http://www.apache.org/licenses/LICENSE-2.0
    +#
    +#  Unless required by applicable law or agreed to in writing, software
    +#  distributed under the License is distributed on an "AS IS" BASIS,
    +#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +#  See the License for the specific language governing permissions and
    +# limitations under the License.
    +################################################################################
    +
    +END_TO_END_DIR="`dirname \"$0\"`"				# relative
    +END_TO_END_DIR="`( cd \"$END_TO_END_DIR\" && pwd )`" 	# absolutized and normalized
    +if [ -z "$END_TO_END_DIR" ] ; then
    +	# error; for some reason, the path is not accessible
    +	# to the script (e.g. permissions re-evaled after suid)
    --- End diff --
    
    inconsistent indentation (tabs vs spaces)


> Move end-to-end test scripts to end-to-end module
> -------------------------------------------------
>
>                 Key: FLINK-8810
>                 URL: https://issues.apache.org/jira/browse/FLINK-8810
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>            Priority: Major
>             Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message