flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8811) Add MiniClusterClient to allow fast MiniCluster operations
Date Fri, 02 Mar 2018 02:57:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383071#comment-16383071
] 

ASF GitHub Bot commented on FLINK-8811:
---------------------------------------

Github user zhangminglei commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5600#discussion_r171754724
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
---
    @@ -178,6 +181,13 @@ public URI getRestAddress() {
     		}
     	}
     
    +	public HighAvailabilityServices getHighAvailabilityServices() {
    +		synchronized (lock) {
    +			checkState(running, "MiniCluster is not yet running.");
    --- End diff --
    
    I am curious about the lock in this place. Is not such a scene as follow ?
    
    Some tests or ITCase running in maven test simultaneously. And might be change this object
at the same time. So, that is why we should have a lock here ?


> Add MiniClusterClient to allow fast MiniCluster operations
> ----------------------------------------------------------
>
>                 Key: FLINK-8811
>                 URL: https://issues.apache.org/jira/browse/FLINK-8811
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 1.5.0, 1.6.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Critical
>              Labels: flip-6
>             Fix For: 1.5.0, 1.6.0
>
>
> We should offer a {{ClusterClient}} implementation for the {{MiniCluster}}. That way
we would be able to submit and wait for result without polling how it would be the case by
using the {{RestClusterClient}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message